Skip to content

Commit aa8bba4

Browse files
committed
[WiP] Remove zend.max_allowed_stack_size=-1 workaround
This reverts commit 3151535 and 81d2281.
1 parent 69c343e commit aa8bba4

File tree

3 files changed

+0
-17
lines changed

3 files changed

+0
-17
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ jobs:
2121
uses: shivammathur/setup-php@v2
2222
with:
2323
php-version: ${{ matrix.php }}
24-
ini-values: zend.max_allowed_stack_size=-1
2524
tools: composer:v2
2625
coverage: none
2726

README.md

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -53,18 +53,6 @@ server can use it to call any native library they have access to.
5353
Of course if attackers are running their own PHP code on your webserver you
5454
are probably already toast, unfortunately.
5555

56-
Finally, on php 8.3 and later you need to disable stack overflow
57-
tests. php-vips executes FFI callbacks off the main thread and this confuses
58-
those checks, at least in php 8.3.0.
59-
60-
Add:
61-
62-
```
63-
zend.max_allowed_stack_size=-1
64-
```
65-
66-
To your `php.ini`.
67-
6856
### Example
6957

7058
```php

src/FFI.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -243,10 +243,6 @@ private static function init(): void
243243
if (!ini_get('ffi.enable')) {
244244
throw new Exception("ffi.enable not set to 'true'");
245245
}
246-
if (version_compare(PHP_VERSION, '8.3', '>=') &&
247-
ini_get('zend.max_allowed_stack_size') != '-1') {
248-
throw new Exception("zend.max_allowed_stack_size not set to '-1'");
249-
}
250246

251247
$vips_libname = self::libraryName("libvips", 42);
252248
if (PHP_OS_FAMILY === "Windows") {

0 commit comments

Comments
 (0)