Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor UploadPicture #1

Open
klimovbv opened this issue Feb 16, 2015 · 0 comments
Open

Refactor UploadPicture #1

klimovbv opened this issue Feb 16, 2015 · 0 comments

Comments

@klimovbv
Copy link
Owner

  1. UploadPicture is not informative enough. If you inherit it from AsyncTask you should at least name it UploadPictureTask.
  2. You mixed up logic and view. Please, read http://en.wikipedia.org/wiki/Model%E2%80%93view%E2%80%93controller . You should handle all the UI related events (such as dialogs or toasts from UI class, like Activity).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@klimovbv