Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShowErrors css class does not exist/not applied to certain fields #16

Open
alucardu opened this issue Mar 29, 2022 · 0 comments
Open

ShowErrors css class does not exist/not applied to certain fields #16

alucardu opened this issue Mar 29, 2022 · 0 comments

Comments

@alucardu
Copy link
Contributor

alucardu commented Mar 29, 2022

Bug
The showErrors class is added to class selecter on the form field but there's actual showErrors class applied to the field:

<klp-form-select
	[options]="options"
	[(ngModel)]="innerValue"
	[placeholder]="'Select condition type' | translate"
	(ngModelChange)="setInnerValueAndNotify($event)"
	[ngClass]="{showErrors: isInErrorState()}"
></klp-form-select>

image

//edit. Seems like the showErrors is applied on a input field:
image

But not on select & number-input fields.

Fix
The showErrors css class should be correctly applied to the field element to show that there's a error.

@alucardu alucardu changed the title ShowErrors css class does not exist/not applied to form field ShowErrors css class does not exist/not applied to certain fields Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant