Template updates #972
Merged
Template updates #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DavidSeptimus-Klotho
commented
Mar 20, 2024
DavidSeptimus-Klotho
commented
- Removes default value for ASG DesiredCapacityType
- Adds support for ECS TaskDefinition container health checks
- Updates Cloudfront configuration to better support load balancer integrations
- Breaking: Adds support for docker volumes in ECS TaskDefinitions
"units" is a platform default value and adding it was causing Pulumi to think the ASG was changing on every update.
…grations - If a downstream alb listener has no methods, cloudfront will allow all methods - Replaced ForwardedValues with CachePolicyId and OriginRequestPolicyId for CF -> ALB edges to disable caching and to forward headers - Removed default values for ForwardedValues on ordered cache behaviors
jhsinger-klotho
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.