From c7281c05d4ee16bf14ea0f11287e0f90070ecdad Mon Sep 17 00:00:00 2001 From: Charles Date: Tue, 16 Feb 2021 17:39:09 -0800 Subject: [PATCH] fixes for slack and its docs (#2091) --- .../41375467-61ae-4204-8e38-e2b8b7365f23.json | 2 +- .../init/src/main/resources/seed/source_definitions.yaml | 2 +- .../connectors/source-slack-singer/Dockerfile | 2 +- .../source-slack-singer/source_slack_singer/source.py | 6 +++--- .../source-slack-singer/source_slack_singer/spec.json | 3 ++- docs/integrations/sources/slack.md | 4 ++-- 6 files changed, 10 insertions(+), 9 deletions(-) diff --git a/airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/41375467-61ae-4204-8e38-e2b8b7365f23.json b/airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/41375467-61ae-4204-8e38-e2b8b7365f23.json index 7d65729d25cd..551ba406d42d 100644 --- a/airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/41375467-61ae-4204-8e38-e2b8b7365f23.json +++ b/airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/41375467-61ae-4204-8e38-e2b8b7365f23.json @@ -2,6 +2,6 @@ "sourceDefinitionId": "41375467-61ae-4204-8e38-e2b8b7365f23", "name": "Slack", "dockerRepository": "airbyte/source-slack-singer", - "dockerImageTag": "0.1.3", + "dockerImageTag": "0.1.4", "documentationUrl": "https://hub.docker.com/repository/docker/airbyte/source-slack-singer" } diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml index 9cec5ef494b5..ced1360901d9 100644 --- a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml @@ -116,7 +116,7 @@ - sourceDefinitionId: 41375467-61ae-4204-8e38-e2b8b7365f23 name: Slack dockerRepository: airbyte/source-slack-singer - dockerImageTag: 0.1.3 + dockerImageTag: 0.1.4 documentationUrl: https://hub.docker.com/repository/docker/airbyte/source-slack-singer - sourceDefinitionId: 59f1e50a-331f-4f09-b3e8-2e8d4d355f44 name: Greenhouse diff --git a/airbyte-integrations/connectors/source-slack-singer/Dockerfile b/airbyte-integrations/connectors/source-slack-singer/Dockerfile index 7872c66c96b5..d5ebdcd8a49f 100644 --- a/airbyte-integrations/connectors/source-slack-singer/Dockerfile +++ b/airbyte-integrations/connectors/source-slack-singer/Dockerfile @@ -6,7 +6,7 @@ ENV CODE_PATH="source_slack_singer" ENV AIRBYTE_IMPL_MODULE="source_slack_singer" ENV AIRBYTE_IMPL_PATH="SourceSlackSinger" -LABEL io.airbyte.version=0.1.3 +LABEL io.airbyte.version=0.1.4 LABEL io.airbyte.name=airbyte/source-slack-singer WORKDIR /airbyte/integration_code diff --git a/airbyte-integrations/connectors/source-slack-singer/source_slack_singer/source.py b/airbyte-integrations/connectors/source-slack-singer/source_slack_singer/source.py index f2af2ad2ba2d..5265961c1cb3 100644 --- a/airbyte-integrations/connectors/source-slack-singer/source_slack_singer/source.py +++ b/airbyte-integrations/connectors/source-slack-singer/source_slack_singer/source.py @@ -38,9 +38,9 @@ def transform_config(self, raw_config): return { "token": raw_config["token"], "start_date": raw_config["start_date"], - "private_channels": str(raw_config["private_channels"]), - "join_public_channels": str(raw_config["join_public_channels"]), - "exclude_archived": str(raw_config["exclude_archived"]), + "private_channels": False, + "join_public_channels": False, + "exclude_archived": True, "date_window_size": "7", } diff --git a/airbyte-integrations/connectors/source-slack-singer/source_slack_singer/spec.json b/airbyte-integrations/connectors/source-slack-singer/source_slack_singer/spec.json index 627cebb9ecbd..10b290e44493 100644 --- a/airbyte-integrations/connectors/source-slack-singer/source_slack_singer/spec.json +++ b/airbyte-integrations/connectors/source-slack-singer/source_slack_singer/spec.json @@ -15,7 +15,8 @@ }, "token": { "type": "string", - "description": "The Slack API token to interact with your Slack workspace." + "description": "The Slack API token to interact with your Slack workspace.", + "airbyte_secret": true } } } diff --git a/docs/integrations/sources/slack.md b/docs/integrations/sources/slack.md index fe4fa774ed16..bc590a4368e3 100644 --- a/docs/integrations/sources/slack.md +++ b/docs/integrations/sources/slack.md @@ -83,11 +83,11 @@ This tutorial assumes that you are an administrator on your slack instance. If y This may look daunting, but the search functionality in the dropdown should make this part go pretty quick. 6. Scroll to the top of the page and click "Install to Workspace". This will generate a "Bot User OAuth Access Token". We will need this in a moment. -7. Now go to your slack instance. For any public channel go to info => more => add apps. In the search bar search for the name of your app. \(If using the desktop version of slack, you may need to restart Slack for it to pick up the new app\). +7. Now go to your slack instance. For any public channel go to info => more => add apps. In the search bar search for the name of your app. \(If using the desktop version of slack, you may need to restart Slack for it to pick up the new app\). Airbyte will only replicate messages from channels that the Slack bot has been added to. ![](../../.gitbook/assets/slack-add-apps.png) -8. In airbyte, create a Slack source. The "Bot User OAuth Access Token" from the earlier should be used as the token. +8. In Airbyte, create a Slack source. The "Bot User OAuth Access Token" from the earlier should be used as the token. 9. You can now pull data from your slack instance! ### Setup guide \(Legacy API Key\)