Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support run-of-network line items (no targeted placements) #16

Open
ptomasroos opened this issue Apr 24, 2017 · 4 comments · May be fixed by #52
Open

Support run-of-network line items (no targeted placements) #16

ptomasroos opened this issue Apr 24, 2017 · 4 comments · May be fixed by #52

Comments

@ptomasroos
Copy link

dfp.exceptions.BadSettingException: The setting "DFP_TARGETED_PLACEMENT_NAMES" must contain at least one DFP placement ID.

IMHO this should default to Run of network in the case of empty array not yield a error. On our case I see exactly no reason to have this targeted against specific placements, or adunits the reason is that one needs to generate many more than just having 1 per bidder which runs for all adunits.

@kmjennison
Copy link
Owner

This makes sense.

When we add this feature, I'd like to protect people who blindly run the script without configuring settings properly, because I believe the most common use case is to target to placements. We could safeguard by adding DFP_ALLOW_NO_INVENTORY_TARGETING that defaults to false.

@ptomasroos Interested in contributing this?

@ptomasroos
Copy link
Author

Thanks for fixen the issues btw @kmjennison, I hacked it locally, will clean up and send a PR in a week or two

@kevinlisota
Copy link

@ptomasroos do you have that PR ready or a sample of what you did? We need run of network as well, not specific adunits or placements. This could save me many hours of tedious work :)

@pboisso
Copy link

pboisso commented Sep 23, 2017

I'd be interested in Run of Network also, does anyone managed to get it done? Thanks!

@pbrisson pbrisson linked a pull request Apr 10, 2018 that will close this issue
pbrisson added a commit to pbrisson/dfp-prebid-setup that referenced this issue Apr 10, 2018
@kmjennison kmjennison changed the title Strange behaviour when not setting DFP_TARGETED_PLACEMENTS_NAMES Support run-of-network line items (no targeted placements) Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants