-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support run-of-network line items (no targeted placements) #16
Comments
This makes sense. When we add this feature, I'd like to protect people who blindly run the script without configuring settings properly, because I believe the most common use case is to target to placements. We could safeguard by adding @ptomasroos Interested in contributing this? |
Thanks for fixen the issues btw @kmjennison, I hacked it locally, will clean up and send a PR in a week or two |
@ptomasroos do you have that PR ready or a sample of what you did? We need run of network as well, not specific adunits or placements. This could save me many hours of tedious work :) |
I'd be interested in Run of Network also, does anyone managed to get it done? Thanks! |
IMHO this should default to Run of network in the case of empty array not yield a error. On our case I see exactly no reason to have this targeted against specific placements, or adunits the reason is that one needs to generate many more than just having 1 per bidder which runs for all adunits.
The text was updated successfully, but these errors were encountered: