Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports the serve of creatives that do not use safeframe. #83

Open
couhie opened this issue Sep 11, 2019 · 3 comments
Open

Supports the serve of creatives that do not use safeframe. #83

couhie opened this issue Sep 11, 2019 · 3 comments
Labels
enhancement

Comments

@couhie
Copy link
Contributor

couhie commented Sep 11, 2019

Some bidders not recommend to serve creatives into a safeframe, now.
I want to enable / disable the serve into a safeframe as an option.
@kmjennison kmjennison mentioned this issue Sep 11, 2019
Open
@kmjennison
Copy link
Owner

Opened an issue to address customization more generally: #84

@adops-tcs
Copy link

Hi @kmjennison - I need to modify the script so "safeframes" box is not checked since we have a bidder whose ads don't render in safeframes.

Would it work if I update create_creatives.py by replacing True with False here?

isSafeFrameCompatible': True,

Thank you!

@kmjennison
Copy link
Owner

@adops-tcs Yes, that change should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@couhie @kmjennison @adops-tcs