Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

give it a smaller default step in the numerical diff #3

Open
eweca-d opened this issue Jun 19, 2024 · 1 comment
Open

give it a smaller default step in the numerical diff #3

eweca-d opened this issue Jun 19, 2024 · 1 comment

Comments

@eweca-d
Copy link

eweca-d commented Jun 19, 2024

The current default step is pub const DEFAULT_STEP_SIZE: f64 = 0.00001;. It is too big for some functions. I would recommend a smaller value pub const DEFAULT_STEP_SIZE: f64 = 1.49e-8. You can find the magic value in a popular python library scipy: https://docs.scipy.org/doc/scipy/reference/generated/scipy.optimize.approx_fprime.html.
@kmolan
Copy link
Owner

kmolan commented Jun 19, 2024

Noted. I'm currently doing a big refactor so this change will take some time. Thank you again for all your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmolan @eweca-d