From 60241d9b7267f9fdce3de6046965c2081ca65496 Mon Sep 17 00:00:00 2001
From: KMY <tt@kmycode.net>
Date: Tue, 26 Sep 2023 18:22:49 +0900
Subject: [PATCH] #32 Add get circle statuses test

---
 .../api/v1/circles/statuses_controller.rb     |  1 -
 .../v1/circles/statuses_controller_spec.rb    | 43 +++++++++++++++++++
 spec/fabricators/circle_status_fabricator.rb  |  6 +++
 3 files changed, 49 insertions(+), 1 deletion(-)
 create mode 100644 spec/controllers/api/v1/circles/statuses_controller_spec.rb
 create mode 100644 spec/fabricators/circle_status_fabricator.rb

diff --git a/app/controllers/api/v1/circles/statuses_controller.rb b/app/controllers/api/v1/circles/statuses_controller.rb
index 84e9b05543a7e2..705731936b27c3 100644
--- a/app/controllers/api/v1/circles/statuses_controller.rb
+++ b/app/controllers/api/v1/circles/statuses_controller.rb
@@ -2,7 +2,6 @@
 
 class Api::V1::Circles::StatusesController < Api::BaseController
   before_action -> { doorkeeper_authorize! :read, :'read:lists' }, only: [:show]
-  before_action -> { doorkeeper_authorize! :write, :'write:lists' }, except: [:show]
 
   before_action :require_user!
   before_action :set_circle
diff --git a/spec/controllers/api/v1/circles/statuses_controller_spec.rb b/spec/controllers/api/v1/circles/statuses_controller_spec.rb
new file mode 100644
index 00000000000000..d56ea1a6f6880f
--- /dev/null
+++ b/spec/controllers/api/v1/circles/statuses_controller_spec.rb
@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+describe Api::V1::Circles::StatusesController do
+  render_views
+
+  let(:user)  { Fabricate(:user) }
+  let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'read:lists') }
+  let(:circle) { Fabricate(:circle, account: user.account) }
+  let(:status) { Fabricate(:status, account: user.account, visibility: 'limited', limited_scope: 'circle') }
+
+  before do
+    allow(controller).to receive(:doorkeeper_token) { token }
+    Fabricate(:circle_status, status: status, circle: circle)
+    other_circle = Fabricate(:circle)
+    Fabricate(:circle_status, status: Fabricate(:status, visibility: 'limited', limited_scope: 'circle', account: other_circle.account), circle: other_circle)
+  end
+
+  describe 'GET #index' do
+    it 'returns http success' do
+      get :show, params: { circle_id: circle.id, limit: 1 }
+
+      expect(response).to have_http_status(200)
+      json = body_as_json
+      expect(json.map { |item| item[:id].to_i }).to eq [status.id]
+    end
+
+    context "with someone else's statuses" do
+      let(:other_account)  { Fabricate(:account) }
+      let(:other_circle)   { Fabricate(:circle, account: other_account) }
+
+      before do
+        Fabricate(:circle_status, circle: other_circle, status: Fabricate(:status, account: other_account, visibility: 'limited', limited_scope: 'circle'))
+      end
+
+      it 'returns http failed' do
+        get :show, params: { circle_id: other_circle.id }
+        expect(response).to have_http_status(404)
+      end
+    end
+  end
+end
diff --git a/spec/fabricators/circle_status_fabricator.rb b/spec/fabricators/circle_status_fabricator.rb
new file mode 100644
index 00000000000000..f190331a3639fc
--- /dev/null
+++ b/spec/fabricators/circle_status_fabricator.rb
@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+Fabricator(:circle_status) do
+  circle { Fabricate.build(:circle) }
+  status { Fabricate.build(:status) }
+end