From c79ae3770e36228e236486d4af592695d60f2d72 Mon Sep 17 00:00:00 2001 From: Pierangelo Di Pilato Date: Thu, 16 Dec 2021 20:16:17 +0100 Subject: [PATCH] Add promote filter function to Broker and Trigger reconciler (#1616) (#1621) When a reconciler gets promoted to be the leader, every object gets re-queued even if it shouldn't be. Signed-off-by: Pierangelo Di Pilato --- control-plane/pkg/reconciler/broker/controller.go | 4 +++- control-plane/pkg/reconciler/trigger/controller.go | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/control-plane/pkg/reconciler/broker/controller.go b/control-plane/pkg/reconciler/broker/controller.go index 2b38c2d4ac..808ef70719 100644 --- a/control-plane/pkg/reconciler/broker/controller.go +++ b/control-plane/pkg/reconciler/broker/controller.go @@ -94,7 +94,9 @@ func NewController(ctx context.Context, watcher configmap.Watcher, configs *Conf reconciler.SetBootstrapServers(configs.BootstrapServers) } - impl := brokerreconciler.NewImpl(ctx, reconciler, kafka.BrokerClass) + impl := brokerreconciler.NewImpl(ctx, reconciler, kafka.BrokerClass, func(impl *controller.Impl) controller.Options { + return controller.Options{PromoteFilterFunc: kafka.BrokerClassFilter()} + }) reconciler.Resolver = resolver.NewURIResolverFromTracker(ctx, impl.Tracker) diff --git a/control-plane/pkg/reconciler/trigger/controller.go b/control-plane/pkg/reconciler/trigger/controller.go index 425253dee9..a262f6841d 100644 --- a/control-plane/pkg/reconciler/trigger/controller.go +++ b/control-plane/pkg/reconciler/trigger/controller.go @@ -81,6 +81,7 @@ func NewController(ctx context.Context, _ configmap.Watcher, configs *config.Env FinalizerName: FinalizerName, AgentName: ControllerAgentName, SkipStatusUpdates: false, + PromoteFilterFunc: filterTriggers(reconciler.BrokerLister), } })