Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint errors #4008

Closed
pierDipi opened this issue Jul 25, 2024 · 6 comments · May be fixed by #4025
Closed

Fix lint errors #4008

pierDipi opened this issue Jul 25, 2024 · 6 comments · May be fixed by #4025
Assignees
@rahulii
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@pierDipi
Copy link
Member

Describe the bug

There are a few lint errors we need to fix https://github.com/knative-extensions/eventing-kafka-broker/actions/runs/10079854577/job/27868194009?pr=4005

Expected behavior

No lint errors

To Reproduce

Run lint GH action

Knative release version
main

Additional context

/good-first-issue
@pierDipi pierDipi added the kind/bug Categorizes issue or PR as related to a bug. label Jul 25, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 25, 2024

@pierDipi:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Describe the bug

There are a few lint errors we need to fix https://github.com/knative-extensions/eventing-kafka-broker/actions/runs/10079854577/job/27868194009?pr=4005

Expected behavior

No lint errors

To Reproduce

Run lint GH action

Knative release version
main

Additional context

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 25, 2024
@rissh
Copy link

rissh commented Jul 25, 2024

Hey @pierDipi ,

I'm planning to work on this issue. Can you please assign me this issue?
Please feel free to provide any suggestions or guidance as I work on this task. I'm open to feedback and would appreciate any insights you might have.

Thank you!

@ukane-philemon
Copy link

'm planning to work on this issue. Can you please assign me this issue?

No one has signified interest before now, you can get the fix ready, PR and cite this issue so @pierDipi can just review the real thing.

@pierDipi
Copy link
Member Author

Thanks @rissh, to get the issue assigned to you, you can comment with /assign and the bot will assign the issue to you.

Feel free to ask any questions you have directly here

@rahulii
Copy link
Contributor

rahulii commented Jul 31, 2024

/assign

@rahulii rahulii mentioned this issue Jul 31, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 30, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulii rahulii

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix lint errors rahulii/eventing-kafka-broker
4 participants
@rahulii @pierDipi @ukane-philemon @rissh