Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Conformance test authoring. #100

Closed
n3wscott opened this issue Feb 22, 2021 · 4 comments
Closed

Support Conformance test authoring. #100

n3wscott opened this issue Feb 22, 2021 · 4 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@n3wscott
Copy link

Need an example conformance test documented for downstreams to reference.

There are a few features we still need that block downstreams from really using the framework for creating conformance test authoring and running:

Add others as they are found.

@vaikas
Copy link
Contributor

vaikas commented Mar 10, 2021

@slinkydeveloper @n3wscott Couple of things based off these samples that came to mind from a quick look:

  1. mtchannelbroker is hardcoded, so what is the recommended way to pass in a different BrokerClass (say, Kakfa)? Or just pass in an already created Broker (by ref? Name?) instead of creating a broker in the test?
  2. I don't see an easy way to test mutations. We have install, but I don't see a way to modify a resource. For example, I'd like to author a test that says: Create MTChannelBasedBroker, then try to change it.

@n3wscott
Copy link
Author

  1. The test for broker conformance is written incorrectly. We need to pass a ref to the broker under test and create the broker external to the conformance run.
  2. The outer wrapper is intended to be copied into the target repo and mutated there, with customizations specific to the test env the rest of the tests need not be aware of.

We are not quite there, I think we can get there in a week.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants