Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Common code across plugins #55

Closed
maximilien opened this issue Jun 23, 2020 · 2 comments
Closed

Common code across plugins #55

maximilien opened this issue Jun 23, 2020 · 2 comments

Comments

@maximilien
Copy link
Contributor

For kn-source-kafka and kn-source-github and various planned plugins, @daisy-ycguo and I have a common set of code we use as kn-source-pkg. We would like to have this here.

While kn-source-pkg is structured like a plugin, it is not. So putting it in this repo’s plugins directory would not be correct. So I am suggesting we create a top level lib directory (like we did for client and put it there. This could also serve for a good place for other such common code.

Thoughts? Please respond soon. I will leave this open after Thursday like the other recent global issues for this repo.

@maximilien
Copy link
Contributor Author

@daisy-ycguo, @rhuss, @navidshaikh See ^^^

Please comment if you have different suggestions or opinions. Thursday’s TOC will also help in case we decide something different.

@maximilien
Copy link
Contributor Author

This is duplicate to #56 since that same repo should contain all common code. So closing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant