Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROCESS CHANGE: Writers or WG leads should get admin powers to repos #1570

Open
Cali0707 opened this issue May 13, 2024 · 4 comments
Open

PROCESS CHANGE: Writers or WG leads should get admin powers to repos #1570

Cali0707 opened this issue May 13, 2024 · 4 comments
Assignees

Comments

@Cali0707
Copy link
Member

From discussion on slack, it would be nice for writers (or at least the WG leads) for various areas to be able to do admin-only actions such as /override various tests on a PR.

Expected benefits

Fewer calls to TOC members to /override on PRs, and no need to wait on someone else when something needs to be overriden.

Expected costs

More people will be admins on repos

@dsimansk
Copy link
Contributor

/cc @knative/productivity-leads

Hi folks, is there a viable way to handle such request via Peribolos config?

@Cali0707
Copy link
Member Author

Cali0707 commented May 14, 2024

@dsimansk one way I could think of doing this is, for each repo where currently there is the write permission, changing that to admin. For example, for the eventing writers group we could change the config to:

Eventing Writers:
        description: Grants write access to eventing-related repositories.
        privacy: closed
        repos:
          eventing: admin
          eventing-contrib: admin
          pkg: admin
          release: admin

(This is currently how the release leads group is configured, but they have the admin permission for all repos)

@dsimansk
Copy link
Contributor

@Cali0707 thanks for the pointer. Yep, makes sense to me. Per you proposal, I'd suggest we grant admin perm on Working Group Lead level at least (with a new group ). Then keep write group for Approvers.

We already have team: definition for WG Leads, probably needs a permission assignment. Pending TOC and Productivity WG approval ofc.

/cc @knative/technical-oversight-committee
/cc @knative/productivity-leads

@psschwei
Copy link
Contributor

I think we can give non-admins the ability to override via the prow config

@dprotaso dprotaso moved this from Needs discussion to In Progress in Technical Oversight Backlog Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

3 participants