Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add health check config and clean up duplicated code #8308

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add health check config and clean up duplicated code #8308

wants to merge 3 commits into from

Conversation

airycanon
Copy link

Fixes #8192

Proposed Changes

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: airycanon
Once this PR has been reviewed and has the lgtm label, please assign lionelvillard for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@airycanon airycanon changed the title Add health check configs and clean up duplicated code Add health check config and clean up duplicated code Nov 6, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 6, 2024

Welcome @airycanon! It looks like this is your first PR to knative/eventing 🎉

@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 6, 2024

Hi @airycanon. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2024
@Cali0707
Copy link
Member

Cali0707 commented Nov 6, 2024

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2024
@airycanon
Copy link
Author

/retest-required

@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 18, 2024

@airycanon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
conformance-tests_eventing_main 8affb05 link true /test conformance-tests
reconciler-tests_eventing_main 8affb05 link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pierDipi
Copy link
Member

@airycanon failures seems related, adapter package is used also by ApiServerSource

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add readiness and liveness probes in pingsource-mt-adapter
3 participants
@airycanon @Cali0707 @pierDipi