-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add resources requests and limits #1571
Conversation
@@ -6245,5 +6245,12 @@ spec: | |||
ports: | |||
- name: metrics | |||
containerPort: 9090 | |||
resources: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these numbers come from any verification or such?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have verified this in my environment on a metrics basis and it works well with this value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not a problem, I'll try to fix the unit test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matzew Your opinion.
Does it seem safe to proceed with implementation?
Thx.
This Pull Request is stale because it has been open for 90 days with |
Signed-off-by: kahirokunn <[email protected]>
a8a8a97
to
a6338f6
Compare
This Pull Request is stale because it has been open for 90 days with |
/remove-lifecycle stale |
This Pull Request is stale because it has been open for 90 days with |
/reopen |
@kahirokunn: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kahirokunn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kahirokunn: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@kahirokunn we ultimately added |
Thanks! |
Fixes #
Proposed Changes
Release Note