Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] set HPA replica values when workload overrides are set #1575

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #1548

The operator now sets HorizontalPodAutoscaler replicas (on resources with HPAs) when workload overrides are defined.

@knative-prow
Copy link

knative-prow bot commented Oct 2, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-prow-robot
Once this PR has been reviewed and has the lgtm label, please assign aliok for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from houshengbo October 2, 2023 09:20
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 2, 2023
@ReToCode
Copy link
Member

ReToCode commented Oct 2, 2023

Does not work because of generated files, so doing it manually:

#1576
and
#1577

@ReToCode
Copy link
Member

ReToCode commented Oct 2, 2023

/close

@knative-prow knative-prow bot closed this Oct 2, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 2, 2023

@ReToCode: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants