Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] Support Eventing TLS #1586

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Oct 9, 2023

Cherry-pick of #1582

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2023
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 9, 2023
@pierDipi pierDipi changed the title [WIP] [release-v1.11] Support Eventing TLS [WIP] [release-1.11] Support Eventing TLS Oct 9, 2023
@pierDipi pierDipi requested a review from creydr October 9, 2023 07:52
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e70b4a6) 79.23% compared to head (ab9a018) 79.23%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.11    #1586   +/-   ##
=============================================
  Coverage         79.23%   79.23%           
=============================================
  Files                41       41           
  Lines              1830     1830           
=============================================
  Hits               1450     1450           
  Misses              276      276           
  Partials            104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi pierDipi changed the title [WIP] [release-1.11] Support Eventing TLS [release-1.11] Support Eventing TLS Oct 9, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2023
@pierDipi
Copy link
Member Author

pierDipi commented Oct 9, 2023

@creydr can you take a look at the backport?

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 0c6e47b into knative:release-1.11 Oct 9, 2023
17 checks passed
@pierDipi pierDipi deleted the eventing-tls-1.11 branch October 9, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants