Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class-based reconcilers can't be hosted in one binary with HA #2109

Open
markusthoemmes opened this issue Apr 29, 2021 · 2 comments
Open

Class-based reconcilers can't be hosted in one binary with HA #2109

markusthoemmes opened this issue Apr 29, 2021 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@markusthoemmes
Copy link
Contributor

/kind bug

Expected Behavior

I can host as many class-based controllers (for example: Ingress reconcilers) as I want in a binary, as long as the classes don't clash.

Actual Behavior

They try to get the same lease and thus only one really works. This is quite similar to #1979.

Steps to Reproduce the Problem

  1. Create a binary that launches two Ingress reconcilers
  2. Launch it and see how it competes for the lease.

Additional Info

This is quite similar to #1979.

I guess the simplest way of fixing it is adding the class filter to the lease name.
@knative-prow-robot knative-prow-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 29, 2021
@markusthoemmes markusthoemmes mentioned this issue Apr 29, 2021
Merged
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 29, 2021
@markusthoemmes
Copy link
Contributor Author

/lifecycle frozen

@knative-prow-robot knative-prow-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markusthoemmes @knative-prow-robot