Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KProbe logic from Drainer #2324

Open
nader-ziada opened this issue Oct 25, 2021 · 5 comments
Open

Remove KProbe logic from Drainer #2324

nader-ziada opened this issue Oct 25, 2021 · 5 comments
Labels
area/networking lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@nader-ziada
Copy link
Member

/area networking

Follow up from Serving PR: knative/serving#12033

A related concern (but I don't think it should block this PR) is why the drainer has KProbe logic in it
https://github.com/knative/pkg/blob/main/network/handlers/drain.go#L157

I think that makes the network.NewProbeHandler a noop in this instance
https://github.com/knative/networking/blob/main/pkg/probe_handler.go#L37
@dprotaso
Copy link
Member

cc @runzexia who included the KProbe logic in the drainer - is there a reason you couldn't consume the handler from knative.dev/networking ?

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2022
@pierDipi
Copy link
Member

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2022
@dprotaso
Copy link
Member

/lifecycle frozen

@knative-prow knative-prow bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants