Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Func version bump step in Backstage release procedures #334

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Func version bump step in Backstage release procedures #334

wants to merge 1 commit into from

Conversation

aliok
Copy link
Member

@aliok aliok commented Oct 21, 2024 •
edited
Loading

Func version bump step in Backstage release procedures

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aliok
Once this PR has been reviewed and has the lgtm label, please assign upodroid for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2024
@aliok aliok mentioned this pull request Oct 21, 2024
Merged
5 tasks
@aliok aliok changed the title [WIP] Func version bump step in Backstage release procedures Func version bump step in Backstage release procedures Oct 22, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
@aliok aliok requested a review from pierDipi October 22, 2024 09:00
@aliok
Copy link
Member Author

aliok commented Oct 22, 2024

cc @pierDipi

@aliok
Copy link
Member Author

aliok commented Oct 23, 2024

/hold

Thanks @dsimansk for catching the logic mistake here.

Main branch in BS plugins repo should use main in Func.

Before the release (during release branch creation), it should be switched to using the Func version that's just released.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode Awaiting requested review from ReToCode

@skonto skonto Awaiting requested review from skonto

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aliok