Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search highlighter uses full-text string instead of createHighlights function #156

Open
svandaalen opened this issue Aug 21, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@svandaalen
Copy link
Collaborator

The new search highlighter uses the full-text string as written by the user, meaning that the highlighter will try to highlight whatever the user writes in the full-text search input field. This causes problems when the user starts using ES query string queries like suriano AND che because the highlighter will try to highlight the entire "suriano AND che" string.

A previous iteration of the search highlighter used the createHighlights function which extracted the search highlights from the ES results, meaning that ES has already interpreted the ES query string query. The new search highlighter should use the same (or similar) function.

@svandaalen svandaalen added the bug Something isn't working label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants