Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically generate default scripts (templates) from connected inputs #83

Open
stelfrich opened this issue Jun 21, 2016 · 6 comments

Comments

@stelfrich
Copy link
Member

This might be hard to achieve / to find a sensible default case: for a beginner it would be useful to have a template with input @Paramters according to the inputs connected to the node.

For tables with a few columns it might be sensible to add those as inputs and have the user remove them instead of having him/her add them one after the other.

@imagejan
Copy link

How about something similar to the Java and R Snippet nodes, where you have a sidebar with all available columns and flow variables, and the necessary variables/parameters are added to the script automatically upon double-clicking any of them?

@stelfrich
Copy link
Member Author

@imagejan That's how it is implemented at the moment which works really nice.

It was just a thought experiment to maybe add the already connected inputs and outputs to the default templates when opening the node's configuration dialog.

@imagejan
Copy link

@stelfrich oh, I see, sorry. Then I'll shut up ;)

@gab1one
Copy link
Member

gab1one commented Jun 21, 2016

I agree that the templates need improvement.

I don't think it would be feasible though to add all inputs and outputs, this.
This can quickly lead to overloaded scripts, I would rather have only the
inputs declared which are used in the script. Otherwise we waste resources by
converting unused inputs, which can be costly (imagine a table with several
columns filled with large images).

@dietzc
Copy link
Member

dietzc commented Jun 21, 2016

I don't think it would be feasible though to add all inputs and outputs, this.
This can quickly lead to overloaded scripts, I would rather have only the
inputs declared which are used in the script. Otherwise we waste resources by
converting unused inputs, which can be costly (imagine a table with several
columns filled with large images).

I agree. I think we could do some auto-guessing, like adding the first image column or so, but I'd not try to be too smart here. Rather I'd provide nice examples on the website (or a video) explaining the concept. Adding inputs as default only helps new users.

@stelfrich
Copy link
Member Author

I vote +1 for adding the first image column as parameter, @dietzc.

Adding inputs as default only helps new users.

Exactly, that's why I think it is a good idea to add a parameter (in a future release) as an example. It might lower the frustration for new users on their first try, maybe making them stick with scripting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants