Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description needs to get added to UIImageTooltipDlg.cpp #264

Open
2 tasks done
UTengine opened this issue Nov 14, 2024 · 1 comment
Open
2 tasks done

Description needs to get added to UIImageTooltipDlg.cpp #264

UTengine opened this issue Nov 14, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@UTengine
Copy link
Contributor

UTengine commented Nov 14, 2024

Search before asking

  • I searched the issues and found no similar issues.

Description

    m_pStr[iIndex]->SetStyle(UI_STR_TYPE_HALIGN, UISTYLE_STRING_ALIGNCENTER);
    sprintf(szBuff, spItem->pItemBasic->szRemark.c_str());

Description to unique, scrolls, stackable, quest items are missing in UIImageTooltipDlg.cpp
I once added a check here once to see if the szRemark string had a size bigger than 0-1 then did index++.
But since we want to stick to official behavior I will leave this to someone else.

image

Use case

Implement It's giving me ebola

Are you willing to work on and submit a PR to address the issue?

  • Yes I am willing to submit a PR!
@UTengine UTengine added the enhancement New feature or request label Nov 14, 2024
@UTengine
Copy link
Contributor Author

if (!spItem->pItemBasic->szRemark.empty()) { // szRemark is not empty, proceed with setting it
m_pStr[iIndex]->SetStyle(UI_STR_TYPE_HALIGN, UISTYLE_STRING_ALIGNCENTER);
sprintf(szBuff, spItem->pItemBasic->szRemark.c_str());
m_pstdstr[iIndex] = szBuff;
iIndex++;
}

@UTengine UTengine mentioned this issue Nov 14, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant