Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] TimeGapSplit with stride #569

Open
FBruzzesi opened this issue Jul 13, 2023 · 2 comments
Open

[FEATURE] TimeGapSplit with stride #569

FBruzzesi opened this issue Jul 13, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@FBruzzesi
Copy link
Collaborator

In the current implementation of TimeGapSplit the argument validation_duration is used as stride as well.

This leads to the impossibility of having overlapping validation periods. What about the possibility of adding a stride parameter to indicate the time shift for the training period?

The concrete use case is as follows: I would like to validate a model that retrains every week but forecast for multiple weeks ahead.

Happy to give it a try in the next following days if there is interest in adding this feature.

@FBruzzesi FBruzzesi added the enhancement New feature or request label Jul 13, 2023
@koaning
Copy link
Owner

koaning commented Jul 18, 2023

I'm open to it, but the maintainers of the project are spread a bit thin (I blame the baby). So it might take a while before we're able to get back to you.

@FBruzzesi
Copy link
Collaborator Author

FBruzzesi commented Jul 18, 2023

Thank you Vincent for getting back to me. I can barely imagine the life with a baby 😁.
As I needed that with a certain urgency I started to work towards a completely independent solution.
I will calmly try to add the feature here as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants