Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to scikit-learn 1.6 #719

Open
FBruzzesi opened this issue Nov 18, 2024 · 1 comment · May be fixed by #720
Open

Transition to scikit-learn 1.6 #719

FBruzzesi opened this issue Nov 18, 2024 · 1 comment · May be fixed by #720

Comments

@FBruzzesi
Copy link
Collaborator

scikit-learn make transition from 1.5 to 1.6 easier for third-party library using scikit-learn utilities will give us some buffer time to adjust to the new changes before they make it to a release. From other discussions it seems that these changes will appear in 1.7.

Before that happens we should decide how to proceed forward. I see the following options:

  • Make a hard cut when scikit-learn 1.7 will come out, and support only version 1.6+
  • Implement logic based on scikit-learn version
    • Coming from some narwhals learnings, this might actually be easier than expected and I would like to give it a try before rejecting the idea
@FBruzzesi
Copy link
Collaborator Author

FBruzzesi commented Nov 19, 2024

It might be a bit patchy but definitly doable. I will open a PR tomorrow. For now I added the new tags and created the function to split check pre and post 1.6 (branch if interested)

@FBruzzesi FBruzzesi linked a pull request Nov 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant