Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with scikit-learn 1.6rc1 #720

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Compatibility with scikit-learn 1.6rc1 #720

wants to merge 5 commits into from

Conversation

FBruzzesi
Copy link
Collaborator

Description

Diff is simpler than expected:

  • Fix order of mixin's inheritance
  • Added the new __sklearn_tags__ to all the classes that changes the default tags
  • Created a utility function in sklego.common that perform validation either via validate_data (scikit>=1.6) or check_X_y and check_array (scikit < 1.6).

There are some checks which are not fully compatible, and one that might be buggy in this RC: check_sample_weight_equivalence seems to fail on every of our estimators that support sample_weight - it might be worth reporting upstream, but I could not pin the issue

Closes #719

@FBruzzesi
Copy link
Collaborator Author

So current tests are all passing, which is definitly a good sign that we did not break anything. I tested with scikit-learn1.6rc1 locally (python3.10, ubuntu) and successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koaning koaning Awaiting requested review from koaning

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transition to scikit-learn 1.6
1 participant
@FBruzzesi