Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Extract virus details and include in VirusDetected #41

Open
abrom opened this issue Oct 25, 2021 · 2 comments
Open

[FEATURE] Extract virus details and include in VirusDetected #41

abrom opened this issue Oct 25, 2021 · 2 comments

Comments

@abrom
Copy link

abrom commented Oct 25, 2021

Great gem @kobaltz thanks!

I've got a requirement to display the type of virus that has been detected. I've already written the changes needed to add this to clamby but thought I'd check if that would be something you'd be interested in merging before creating the PR.

Basically just modifying the Command class, specifically the .scan and #run methods to parse the console output and include the parsed virus type when raising the VirusDetected error. My change swaps out the system call with a Open3 library function call to peek at the output and error streams.

Thoughts?

@abrom
Copy link
Author

abrom commented Nov 2, 2021

@arianf
Copy link

arianf commented Jan 12, 2022

I've been waiting for this feature foreverrrr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants