Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sops-decoder is using aws-sdk v2 which is being deprecated soon - should switch to aws-sdk v3 #13

Open
chris-grabcad opened this issue Jul 5, 2023 · 0 comments · May be fixed by #14
Open

Comments

@chris-grabcad
Copy link
Contributor

sops-decoder uses v2 of the sdk, and it should really be upgraded to use v3.

I gave this a go locally, and hit a snag with this code block

      return new aws.KMS({
        region,
        accessKeyId: keyid,
        secretAccessKey: secretkey,
        sessionToken: token,
      });

It seems that accessKeyId no longer exists :-(

image

I will keep trying, I'm pretty sure I can work it out, but my main obstacle is that I'm not sure how to test this piece of code

There were a few other minor issues like this

image

new aws.STS() - required a parameter (unlike before?) so I just put {} in - also not sure if I can easily test this path either.

Best I can do testing wise is use yarn link from my local version of sops-decoder and try with my AWS creds to decode a sops file.

@koblas koblas linked a pull request Jul 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant