Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

critical file not exist #1

Open
ToughStyle opened this issue Oct 2, 2023 · 6 comments
Open

critical file not exist #1

ToughStyle opened this issue Oct 2, 2023 · 6 comments

Comments

@ToughStyle
Copy link

Hi, Vasileios, firstly thanks a lot for sharing this repo.
When I'm trying to run your code, there is a critical file database.datasets.targets missing as below:

from database.datasets.targets.market_limit_orders_builder import MarketLimitOrdersBuilder

Would you please check this file, and upload it, thanks again!

@kochlisGit
Copy link
Owner

Hello,
thanks for letting us know. Can you tell me which file shows this error?

@ToughStyle
Copy link
Author

ToughStyle commented Oct 2, 2023

The file database/datasets/targets/market_limit_orders_builder.py (which contains the classMarketLimitOrdersBuilder) doesn't exist, and thus I can't run the whole project

I found the problem in the file validate_environment.py, which needs to import the classMarketLimitOrdersBuilder in line 5

And another problem is in line 36 of file validate_environment.py:

train_reward_fn = RewardFunction(targets=y_train, fees_percentage=fees_percentage)

the args targets=y_train, fees_percentage=fees_percentage don't match the RewardFunction

@kochlisGit
Copy link
Owner

It looks like you are right. TraderNet-CRv2 is no longer maintained. However, TraderNet-CRv3 will be released today. I will update the entire repository today. Check later

@ToughStyle
Copy link
Author

It looks like you are right. TraderNet-CRv2 is no longer maintained. However, TraderNet-CRv3 will be released today. I will update the entire repository today. Check later

Really?I'm excited to see that update, and do you mean today or this month or this year?

@kochlisGit
Copy link
Owner

This week. I will post the repository url of the new TraderNet to README and on this issue as well.

@RGermain97
Copy link

@kochlisGit Hello Vasileios, I just wanted to say thanks for sharing this framework, I'm excited to test it in live simulation. I was just wondering, you mentioned TraderNet-CRv3 was to be released, where can I access this repository?

Best regards,

Ryan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants