Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust social media cards previews // rmrk2 left #5567

Closed
11 of 15 tasks
yangwao opened this issue Apr 8, 2023 · 19 comments
Closed
11 of 15 tasks

Robust social media cards previews // rmrk2 left #5567

yangwao opened this issue Apr 8, 2023 · 19 comments
Labels
A-seo-search-socials A-worker our cf workers (minions) p2 core functionality, or is affecting 60% of app

Comments

@yangwao
Copy link
Member

yangwao commented Apr 8, 2023

I believe we've faced numerous outages on social media cards and it's time to squash and focus on working version as it's perfect occasion to fix things on this page when we will be releasing new collection

Social media cards are powerful way to drive great conversions, raise CTR to our platform and convince people to click. If we are showing more insightful information it's more tempting to come over. I would like to see being done just about release collection to go together with this release.

I sense most of stuff already being done, yet it's need to be improvised somewhere in code?

Test

Tasks

working at socials

rendering for pages

  • gallery item
  • collection
  • profile

protocols

Ref

@preschian
Copy link
Member

preschian commented Apr 10, 2023

Test

currently won't work on canary.kodadot.xyz because this subdomain serves our pages with netlify. we can check on server: section

image

will work on canary-cf.kodadot.xyz. because this subdomain served on cf-pages

image

we have 2 options to solve that:

  1. create and deploy netlify-edge. something like ssr-opengraph on workers, but for netlify-edge. ref: https://www.netlify.com/products/edge/
  2. pointing canary.kodadot.xyz to cf-pages

which one is suitable for us?

edit: seem like number 2 easier? wdyt? less script to manage for opengraph?

@yangwao
Copy link
Member Author

yangwao commented Apr 10, 2023

so, just swap record I guess?
Like canary.kodadotxyz & beta.kodadot.xyz will be pointing on CF builds?
I think sure can do it if that's thing that would help.

@preschian like this?
canary.kodadot.xyz should be pointing to cf-pages now

image

@preschian
Copy link
Member

@preschian like this?
canary.kodadot.xyz should be pointing to cf-pages now

correct 👍

now, this link should be working https://www.opengraph.xyz/url/https%3A%2F%2Fcanary.kodadot.xyz%2Frmrk%2Fgallery%2F8720634-66fae573cab828190c-KNRY-KANARY_110-0000000000000110

Screenshot 2023-04-10 at 20 40 37

@yangwao
Copy link
Member Author

yangwao commented Apr 10, 2023

@yangwao
Copy link
Member Author

yangwao commented Apr 10, 2023

Maybe @JustLuuuu can lurk if she can notice where it doesn't work for her?

@yangwao
Copy link
Member Author

yangwao commented Apr 10, 2023

It's possible doesn't work for rmrk2?
Is this one related?

@yangwao
Copy link
Member Author

yangwao commented Apr 10, 2023

Twitter seems works well
image

@yangwao
Copy link
Member Author

yangwao commented Apr 10, 2023

Seems when there is in the url of collection ?page=1 doesn't fetch well?

https://canary.kodadot.xyz/bsx/collection/2106275273?page=1

https://canary.kodadot.xyz/bsx/collection/2106275273 but w/o works

image

@preschian
Copy link
Member

preschian commented Apr 11, 2023

Seems this one doesn't work, but I see item well so..

right now, I can't open canary at all. is there any changes maybe?

  • main.nft-gallery-5ci.pages.dev

image

edit: it works now

It's possible doesn't work for rmrk2? Is this one related?

yes, related to that one

@JustLuuuu
Copy link
Member

As I mentioned. They are not working in the chat on Twitter - if you share a specific NFT or profile. If you share the collection in chat that one is working.

Sharing profiles does not work in your feed too.

@preschian
Copy link
Member

They are not working in the chat on Twitter

not sure what the root cause for this, on it

Sharing profiles does not work in your feed too.

I just redeploy it again, could you check again?

@preschian
Copy link
Member

preschian commented Apr 11, 2023

They are not working in the chat on Twitter

somehow it works for me

user profile collection item
Screenshot 2023-04-11 at 15 29 15 Screenshot 2023-04-11 at 15 31 06 Screenshot 2023-04-11 at 15 31 19 Screenshot 2023-04-11 at 15 33 33

dear @/elonmusk, don't broke twitter yet :(

@JustLuuuu
Copy link
Member

dear @/elonmusk, don't broke twitter yet :(

okay works for me too now with NFTs and collections. not with profiles, but I guess that bearable :D

@yangwao
Copy link
Member Author

yangwao commented Apr 11, 2023

Anything we can help on this? or it's working then and should be same working on production I guess?

@yangwao yangwao changed the title Robust social media cards previews Robust social media cards previews // rmrk2 left Apr 12, 2023
@yangwao
Copy link
Member Author

yangwao commented Apr 16, 2023

@yangwao
Copy link
Member Author

yangwao commented Apr 18, 2023

I think if we close loading on Telegram this is good to go, maybe worth test other messengers like

  • WhatsApp
  • Facebook Messenger
  • Signal
  • Viber
  • iMessages
  • Instagram DMs
  • Slack

@preschian
Copy link
Member

  • Doesnt load on telegram

not sure why it doesn't load on telegram 🤔 hhmm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-seo-search-socials A-worker our cf workers (minions) p2 core functionality, or is affecting 60% of app
Projects
None yet
Development

No branches or pull requests

4 participants