Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose websocket TLSClientConfig #95

Open
techjanitor opened this issue Feb 22, 2015 · 0 comments
Open

Expose websocket TLSClientConfig #95

techjanitor opened this issue Feb 22, 2015 · 0 comments

Comments

@techjanitor
Copy link
Contributor

I think it would be good to have the option to configure TLSClientConfig in Gorilla websocket. This would enable the utilization of unsigned certs which seems to be an impossibility right now for wss (?)

http://godoc.org/github.com/gorilla/websocket#Dialer

&tls.Config{InsecureSkipVerify: true}
&tls.Config{RootCAs: certs}

It could potentially be a setting in the Client struct, much like how Kite has TLSConfig for its listener. Or it could just inherit c.LocalKite.TLSConfig when c.dial initializes &sockjsclient.DialOptions.

In addition, a method of setting the TLSConfig for k.kontrol.Client would be useful as well.

I tried to implement this myself but I ran into some strange issues with heartbeat session authentication between a client and kontrol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant