Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI: A review of this package #75

Open
chainsawriot opened this issue Apr 11, 2024 · 5 comments
Open

FYI: A review of this package #75

chainsawriot opened this issue Apr 11, 2024 · 5 comments

Comments

@chainsawriot
Copy link

There is a tidbit about this package in this now widely shared blog post.

As you can see, it is under the "implicit type conversions". But after "a reader of this blog" (you can guess who he is) pointed out the factual error in the accusation, it is not about implicit type conversions at all. Instead, it is about whether batch_size should be a proportion and according to the writer, 3 persons didn't understand what does batch_size mean.

I think the documentation has explained clearly what the batch_size does and in my opinion, it makes a lot of sense for it to be a proportion. But I am afraid some people might think that this parameter works similarly to gensim's chunksize.

@koheiw
Copy link
Owner

koheiw commented Apr 11, 2024

Thanks. I am happy that my package attracted people's attention. Do you think this document help the users?

@chainsawriot
Copy link
Author

@koheiw Yes, this document would definitely be helpful.

@koheiw
Copy link
Owner

koheiw commented Apr 11, 2024

It is linked from the README of this repo as "working paper" but I was not really working on it... I should update it to answer questions like this or that. Where do you think I should publish it?

@chainsawriot
Copy link
Author

Well, for this working paper, I would say arxiv/socarxiv would be nice. For the subsequent actual paper, I am afraid I am not an expert. But you can try like Computational Communication Research's Tool Announcements.

@koheiw
Copy link
Owner

koheiw commented Apr 11, 2024

Thanks! I never thought about the Tool Announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants