Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add a Option to Disable Translator in One Command Invocation #122

Closed
MaikoTan opened this issue Nov 20, 2022 · 2 comments · Fixed by #123
Closed

Feature: Add a Option to Disable Translator in One Command Invocation #122

MaikoTan opened this issue Nov 20, 2022 · 2 comments · Fixed by #123

Comments

@MaikoTan
Copy link
Member

Scope

NovelAI, NAIFU, Stable Diffusion WebUI (AUTOMATIC1111), Others

Describe the problem related to the feature request

Per #58 (comment)

Describe the solution you'd like

  1. Add a new option says --disable-translate (maybe there's better naming)
  2. If no translator available or config.translator is false, ignore it.
  3. If translator(s) available and config.translator is true
    3.1 If the option in 1) is false, translate the prompt
    3.2 If the option in 1) is true, not translate the prompt

Describe alternatives you've considered

As #117
Disable translate there are only English words.

Additional context

No response

@shigma
Copy link
Member

shigma commented Nov 20, 2022

Is there another requirement to manually enable translation when config.translator is set to false?

@MaikoTan
Copy link
Member Author

I didn't know there are. So I shamefully assume the answer is no.
Most reports pointed out that the translators always get you a false result.

When the user is trying generate wonderful pictures, they would usually use English words and don't want their prompt to be messed up by the baka translator.
On the other hand (no offense by the way), when user is using another language to describe their image, it would be more like playing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants