Skip to content

Commit d5c85c6

Browse files
committed
MAINT: PR 54 revisions
* compile using genuine `bool` type instead of an alias * this seems to succeed at build stage, but a few tests do fail at the moment [skip ci]
1 parent 2b961fe commit d5c85c6

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

include/traits.hpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ VIEW_DATA_DIMS(8, T ********)
7575
// the first string identifier is the "canonical name" (i.e. what gets encoded)
7676
// and the remaining string entries are used to generate aliases
7777
//
78-
typedef uint8_t bool_t;
79-
8078
VIEW_DATA_TYPE(int8_t, Int8, "int8", "signed_char")
8179
VIEW_DATA_TYPE(int16_t, Int16, "int16", "short")
8280
VIEW_DATA_TYPE(int32_t, Int32, "int32", "int")
@@ -87,8 +85,7 @@ VIEW_DATA_TYPE(uint32_t, Uint32, "uint32", "unsigned", "unsigned_int")
8785
VIEW_DATA_TYPE(uint64_t, Uint64, "uint64", "unsigned_long")
8886
VIEW_DATA_TYPE(float, Float32, "float32", "float")
8987
VIEW_DATA_TYPE(double, Float64, "float64", "double")
90-
// TODO: real bool type instead of alias
91-
VIEW_DATA_TYPE(bool_t, Bool, "bool", "bool_")
88+
VIEW_DATA_TYPE(bool, Bool, "bool", "bool_")
9289

9390
//----------------------------------------------------------------------------//
9491
// <data-type> <enum> <string identifiers>

0 commit comments

Comments
 (0)