Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shellcheck errors: missing array quoting #9

Closed
pabs3 opened this issue Jun 17, 2020 · 2 comments
Closed

shellcheck errors: missing array quoting #9

pabs3 opened this issue Jun 17, 2020 · 2 comments

Comments

@pabs3
Copy link

pabs3 commented Jun 17, 2020

There are two shellcheck errors:

$ shellcheck --severity error wifi-qr

In wifi-qr line 114:
  for l in ${wifilist[@]}; do
           ^------------^ SC2068: Double quote array expansions to avoid re-splitting elements.


In wifi-qr line 120:
  for m in ${array[@]}; do
           ^---------^ SC2068: Double quote array expansions to avoid re-splitting elements.

If you remove the severity flag you will see that there are lots of other issues with the script too.

@kokoye2007
Copy link
Owner

Thanks
I will fix and update at 0.1-2 version.
<3

kokoye2007 added a commit that referenced this issue Jun 17, 2020
suggest via #9 @pabs3  
shellcheck --severity error wifi-qr
@pabs3
Copy link
Author

pabs3 commented Jun 17, 2020 via email

kokoye2007 added a commit that referenced this issue Jun 17, 2020
kokoye2007 added a commit that referenced this issue Apr 19, 2023
wifi-qr (0.2-2) unstable; urgency=medium
.
  * Improve Summary. (Closes: #989034)
  * QR Code Scan from File Function Update.
.
wifi-qr (0.2-1) unstable; urgency=medium
.
  * Shellcheck and close issue #9
.
wifi-qr (0.1-1) unstable; urgency=medium
.
  * Initial upload.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants