Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm output is logged as ERROR for successful helm:push (unsolved helm issue) #275

Open
koenverwimp opened this issue Mar 13, 2023 · 9 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@koenverwimp
Copy link

AWS ECR now supports pushing helm charts (see https://docs.aws.amazon.com/AmazonECR/latest/userguide/push-oci-artifact.html). I tried to push a helm with the plugin but the "oci://" protocol is not supported.

[ERROR] Failed to execute goal com.kiwigrid:helm-maven-plugin:5.5:upload (default-upload) on project ams-docker: Error uploading /Users/.../....tgz to oci://xxxxxx.dkr.ecr.eu-west-1.amazonaws.com: unknown protocol: oci -> [Help 1]

@sschnabe
Copy link
Member

This was implemented with version 6.1.0 with #120. You are using the old maven coordinates, please use: mvn io.kokuwa.maven:helm-maven-plugin:6.6.1:push

@koenverwimp
Copy link
Author

I think i might just not filled in the correct repo type, but i only see these 3 options.
Keeping chartmuseum still gives the same issue. What type should i use for AWS ECR

Failed to execute goal io.kokuwa.maven:helm-maven-plugin:6.6.1:upload (default-upload) on project ams-docker: Upload failed.: unknown protocol: oci -> [Help 1]

public enum RepoType {
CHARTMUSEUM, ARTIFACTORY, NEXUS
}

@sschnabe
Copy link
Member

@koenverwimp
Copy link
Author

Sorry to disturb you further about this:

In the link they don't provide the "type" tag but i keep getting issues with this Repository type field.

Failed to execute goal io.kokuwa.maven:helm-maven-plugin:6.6.1:upload (default-upload) on project ams-docker: Execution default-upload of goal io.kokuwa.maven:helm-maven-plugin:6.6.1:upload failed: Repository type missing. Check your plugin configuration. -> [Help 1]

@koenverwimp
Copy link
Author

Ah wait, i might be doing helm:upload instead of helm:push.

@koenverwimp
Copy link
Author

koenverwimp commented Mar 15, 2023

image

It looks strange ... i get the error but that the maven succeed and the build is green. The helm is even pushed successfully.

@sschnabe
Copy link
Member

Thx, is wasn't aware of this.

@sschnabe sschnabe reopened this Mar 15, 2023
@sschnabe sschnabe self-assigned this Mar 15, 2023
@sschnabe sschnabe added the bug Something isn't working label Mar 15, 2023
@sschnabe sschnabe changed the title Support for AWS ECR Helm output is logged as ERROR for successful helm:push Mar 15, 2023
@sschnabe
Copy link
Member

Not an issue of this maven plugin, this comes from helm: helm/helm#11533

@sschnabe sschnabe added the documentation Improvements or additions to documentation label Mar 24, 2023
@sschnabe sschnabe changed the title Helm output is logged as ERROR for successful helm:push Helm output is logged as ERROR for successful `helm:push, see helm/helm/issues/11533 Mar 24, 2023
@sschnabe sschnabe changed the title Helm output is logged as ERROR for successful `helm:push, see helm/helm/issues/11533 Helm output is logged as ERROR for successful helm:push Mar 24, 2023
@sschnabe sschnabe changed the title Helm output is logged as ERROR for successful helm:push Helm output is logged as ERROR for successful helm:push (unsolved helm issue) Aug 6, 2023
@sschnabe sschnabe pinned this issue Aug 6, 2023
@sschnabe sschnabe unpinned this issue Aug 6, 2023
@steromano87
Copy link

@koenverwimp @sschnabe a similar issue (successful login message marked as an error) happens also when logging in into an OCI registry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Development

No branches or pull requests

3 participants