Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to exclude tgz from being uploaded to a chart repository #395

Open
lmartella1 opened this issue Dec 19, 2024 · 0 comments
Open

Comments

@lmartella1
Copy link

Is this a request for help?:


Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

Environment (plugin version, maven version, OS, ...):
Plugin Version: 6.15.0
Maven Version: 3.9.6
OS: Linux/MacOs

What happened:
When using the plugin to upload Helm charts to a chart repository, we want to exclude specific .tgz files to avoid uploading sub-charts.

Assuming outputDirectory be ${project.build.directory}/helm (which resolves to target/helm) with the below content:

find target/helm -type f -name "*.tgz" 
target/helm/app-chart-0.1-SNAPSHOT.tgz
target/helm/charts/library-chart/charts/subchart-1.1.0.tgz

The helm-maven-plugin tries to upload both .tgz to the specified chart repository:

[DEBUG] Found chart file for upload: /Users/lmartella/Dev/app/target/helm/app-chart-0.1-SNAPSHOT.tgz
[DEBUG] Found chart file for upload: /Users/lmartella/Dev/app/target/helm/charts/library-chart/charts/subchart-lib-1.1.0.tgz

What you expected to happen:
It would be helpful to have an exclude property to filter out subdirectories containing .tgz files that should not be pushed.

For instance, by setting:

<uploadExcludes>
  <uploadExclude>${project.build.directory}/helm/charts/*</uploadExclude>
</uploadExcludes>	

I would expect the helm maven plugin to only push the following artefact and exclude all the ones under charts/*:

[DEBUG] Found chart file for upload: /Users/lmartella/Dev/app/target/helm/app-chart-0.1-SNAPSHOT.tgz

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

We use the helm-maven-plugin only for the upload goal, as Helm packaging is handled by Quarkus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant