You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, audiojs is a great plugin, but there are still places to be improved.
e.g:
While I use
AudioJS.createAll({
createPlayer: {
loadingClass: 'audioloading'
}
});
The whole players createPlayer is just totally overwritten by the new option, not merge I mean.
It may because the object is just overwritten by a new one instead of merging the two.
if (options) this.helpers.merge(s, options);
this line need to add a extra merge for the createPlayer object
The text was updated successfully, but these errors were encountered:
First, audiojs is a great plugin, but there are still places to be improved.
e.g:
While I use
AudioJS.createAll({
createPlayer: {
loadingClass: 'audioloading'
}
});
The whole players createPlayer is just totally overwritten by the new option, not merge I mean.
It may because the object is just overwritten by a new one instead of merging the two.
if (options) this.helpers.merge(s, options);
this line need to add a extra merge for the createPlayer object
The text was updated successfully, but these errors were encountered: