Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency python-magic-bin seems to be unmaintained #95

Closed
satya-waylit opened this issue Oct 15, 2024 · 9 comments
Closed

Dependency python-magic-bin seems to be unmaintained #95

satya-waylit opened this issue Oct 15, 2024 · 9 comments

Comments

@satya-waylit
Copy link

I ran into an error trying to resolve kolo using uv. I'm using Python 3.12. Seems python-magic-bin hasn't seen an update since 2017. The package python-magic seems to be maintained. Any chance to switch to a maintained dependency?

× No solution found when resolving dependencies:
0.719   ╰─▶ Because python-magic-bin==0.4.14 has no wheels with a matching platform
0.719       tag and you require python-magic-bin==0.4.14, we can conclude that your
0.719       requirements are unsatisfiable.
@wilhelmklopp
Copy link
Member

👋 Hey @satya-waylit

Thanks for the report, I've looked into it a bit and looks like we install python-magic-bin on Windows to make sure mocket works. Just to confirm, are you on Windows? And could you run uv tree and paste the result in this thread?

Ultimately, it looks like when this PR gets merged, we'll be able to remove our dependency on python-magic-bin: ahupp/python-magic#294

But until then, I'm not sure if there is an easy resolution. Are you able to run with WSL as opposed to with windows directly?

@satya-waylit
Copy link
Author

@wilhelmklopp Indeed, using Windows. I was using WSL for the longest, but WSL seems to getting very unstable these days. May be that's why I ran into this issue. Will wait for the upstream fix.

@satya-waylit
Copy link
Author

I checked mocket's code and it seems magic should be an optional dependency. mindflayer/python-mocket#254

@ddelange
Copy link

I see that kolo specifies python-magic-bin ; platform_system == 'Windows'.

My PR on python-magic builds win32 and win_amd64 wheels, just like python-magic-bin does.

The error in the issue description implies that the user is on platform_system Windows, but no wheels available for his distribution according to uv.

Maybe ARM64 Windows? In that case, my PR won't solve OP's issue.

@satya-waylit
Copy link
Author

amd64 in my case

@ddelange
Copy link

ddelange commented Oct 19, 2024

then you should be covered 🤔

can you post the output here of the following direct reference install of python-magic-bin?

pip install --force-reinstall https://files.pythonhosted.org/packages/07/c2/094e3d62b906d952537196603a23aec4bcd7c6126bf80eb14e6f9f4be3a2/python_magic_bin-0.4.14-py2.py3-none-win_amd64.whl

@ddelange
Copy link

and also the output of

python -c 'from packaging.markers import default_environment; print(default_environment())'

@satya-waylit
Copy link
Author

@wilhelmklopp The mocket author has switch to puremagic from python-magic in the newest version. Hopefully that'll solve the problem.

@wilhelmklopp
Copy link
Member

python-magic-bin dropped as a dependency in kolo as of v2.33.9 – nice work on getting this in front of the right people @satya-waylit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants