From f9b9f507fe54c281648b86dfa1e4f1b2148a0dcd Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Mon, 7 Oct 2024 17:38:42 -0400 Subject: [PATCH] tasks: Use set -e in rpm-ostree task Related to https://gitlab.com/redhat/centos-stream/containers/bootc/-/merge_requests/248 Basically a while ago the rpm-ostree task was forked from the buildah task and we didn't inherit the later change to use `set -e` (as we should) on the inner shell script, meaning we had the default "blindly stumble forward when we hit an error" which is never what we want. This would have helped focus the problem on cachi2, not selinux. Signed-off-by: Colin Walters --- task/rpm-ostree/0.2/rpm-ostree.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/task/rpm-ostree/0.2/rpm-ostree.yaml b/task/rpm-ostree/0.2/rpm-ostree.yaml index 2a441e026..19cbe756b 100644 --- a/task/rpm-ostree/0.2/rpm-ostree.yaml +++ b/task/rpm-ostree/0.2/rpm-ostree.yaml @@ -124,6 +124,8 @@ spec: cat >scripts/script-build.sh <<'REMOTESSHEOF' #!/bin/sh set -o verbose + set -eu + set -o pipefail cd $(workspaces.source.path) if [ -z "$CONFIG_FILE" ] ; then CONFIG_FILE_ARG=""