feat(HACBS-2422): add finalizer to Release PRs #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalina
reviewed
Aug 16, 2023
johnbieren
previously approved these changes
Aug 16, 2023
mmalina
previously approved these changes
Aug 17, 2023
johnbieren
previously approved these changes
Aug 17, 2023
|
/retest |
|
/retest |
1 similar comment
|
/retest |
johnbieren
reviewed
Aug 31, 2023
davidmogar
force-pushed
the
hacbs2422
branch
2 times, most recently
from
a6eb27f to
080bfab
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 85.45% 85.05% -0.40%
==========================================
Files 23 23
Lines 1437 1459 +22
==========================================
+ Hits 1228 1241 +13
- Misses 150 156 +6
- Partials 59 62 +3
☔ View full report in Codecov by Sentry. |
This change adds a finalizer to Release PipelineRuns to avoid their deletion by external entities until the Release service has finished processing them. Signed-off-by: David Moreno García <[email protected]>
johnbieren
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a finalizer to Release PipelineRuns to avoid their deletion by external entities until the Release service has finished processing them.
Notice that tests relying on finalizeRelease don't check if the PipelineRun was successfully deleted anymore. The removal of the finalizer is not instant so to test that, we would have to use Eventually blocks, which we know are flaky.