-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RELEASE-1109): allow tenant and managed pipelines to run #549
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just read it in diagonal and added some comments. We can discuss them offline (and maybe address them) before I do a proper review.
5a38216
to
cf0306f
Compare
5164476
to
951d6cf
Compare
bbb4012
to
6ca7b1e
Compare
c5947b7
to
2181559
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
+ Coverage 83.75% 84.09% +0.34%
==========================================
Files 26 26
Lines 1508 1635 +127
==========================================
+ Hits 1263 1375 +112
- Misses 173 182 +9
- Partials 72 78 +6 ☔ View full report in Codecov by Sentry. |
2181559
to
4860148
Compare
4860148
to
2c63a00
Compare
b69a343
to
4661c37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking ok to me once the open discussions are resolved.
4661c37
to
fce6513
Compare
lgtm. Maybe link the new PR here (or the new ticket) of the work on the metrics will be done. |
fce6513
to
aa909c8
Compare
New changes are detected. LGTM label has been removed. |
This commit modifies the release controller to execute both a tenant and managed pipelineRun in the same Release if both are defined. Signed-off-by: Johnny Bieren <[email protected]>
aa909c8
to
9d2ba52
Compare
Okay, I squashed the commits down then. Can you clarify? What new PR or ticket? What metrics work needs to be done? It sounds like this is something for a new ticket, but I will need some more details before filing it |
Sorry. I misunderstood what you said. I thought you wanted to do more changes besides the one I requested (which lgtm). So please ignore the comment! |
This commit modifies the release controller to execute both a tenant and managed pipelineRun in the same Release if both are defined.