fix(KFLUXBUGS-1754): rp shouldn't show matched if RPA doesn't exist #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happybhati
approved these changes
Oct 18, 2024
mmalina
approved these changes
Oct 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
==========================================
- Coverage 84.21% 82.40% -1.81%
==========================================
Files 26 26
Lines 1742 2103 +361
==========================================
+ Hits 1467 1733 +266
- Misses 191 286 +95
Partials 84 84 ☔ View full report in Codecov by Sentry. |
|
/retest |
1 similar comment
|
/retest |
This commit fixes the loader function to return nil instead of an empty RPA if the RPA specified in the RP label does not exist. Signed-off-by: Johnny Bieren <[email protected]>
johnbieren
force-pushed
the
kfluxbugs1754
branch
from
23a5b32 to
5486574
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the loader function to return nil instead of an empty RPA if the RPA specified in the RP label does not exist.