-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update ec API to v0.1.67 #613
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zregvart
force-pushed
the
pr/update-ec-api
branch
from
November 20, 2024 15:05
71ca5d0
to
b7fa71a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
- Coverage 82.38% 78.99% -3.39%
==========================================
Files 26 28 +2
Lines 2123 2247 +124
==========================================
+ Hits 1749 1775 +26
- Misses 289 388 +99
+ Partials 85 84 -1 ☔ View full report in Codecov by Sentry. |
Looks like a quay.io flake:
|
/retest |
zregvart
force-pushed
the
pr/update-ec-api
branch
2 times, most recently
from
November 21, 2024 15:34
aafe432
to
34ad318
Compare
/retest |
simonbaird
approved these changes
Nov 25, 2024
The EC API is now using golang 1.22 so version bumps of it would update the golang version in go.mod, pulled this in a separate commit. The changes to GitHub Actions Workflow files allow future updates to be done solely in the go.mod file. Signed-off-by: Zoran Regvart <[email protected]>
Update the enterprise-contract-controller from v0.1.50 to v0.1.67. This brings a few changes introduced to the EnterpriseContractPolicy CRD. This is important to ensure these changes are picked up during a release pipeline. Ref: https://issues.redhat.com/browse/EC-1000 Signed-off-by: Zoran Regvart <[email protected]>
zregvart
force-pushed
the
pr/update-ec-api
branch
from
December 2, 2024 15:01
34ad318
to
fd388e9
Compare
/retest |
johnbieren
approved these changes
Dec 2, 2024
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the enterprise-contract-controller from v0.1.50 to v0.1.67. This brings a few changes introduced to the EnterpriseContractPolicy CRD.
This is important to ensure these changes are picked up during a release pipeline.
Ref: https://issues.redhat.com/browse/EC-1000
Also includes update to golang 1.22 and RHEL to 9.5