fix(KFLUXBUGS-1921): auto-release false RPA should end reconcile #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happybhati
approved these changes
Dec 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
==========================================
+ Coverage 78.99% 79.21% +0.22%
==========================================
Files 28 28
Lines 2247 2247
==========================================
+ Hits 1775 1780 +5
+ Misses 388 384 -4
+ Partials 84 83 -1 ☔ View full report in Codecov by Sentry. |
If a ReleasePlanAdmission is found with auto-release set to false, it will continually requeue the error because it is not a not found error. Instead, the Release should be marked as validation false and reconciliation should end. Signed-off-by: Johnny Bieren <[email protected]>
johnbieren
force-pushed
the
kfluxbugs1921
branch
from
91d34f2 to
e586d10
Compare
|
New changes are detected. LGTM label has been removed. |
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a ReleasePlanAdmission is found with auto-release set to false, it will continually requeue the error because it is not a not found error. Instead, the Release should be marked as validation false and reconciliation should end.