Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path_open all flags support #6

Open
pmp-p opened this issue Nov 13, 2024 · 6 comments
Open

path_open all flags support #6

pmp-p opened this issue Nov 13, 2024 · 6 comments

Comments

@pmp-p
Copy link
Contributor

pmp-p commented Nov 13, 2024

it seems path_open does not allocate fd when passed OFLAGS_CREAT, does not handle OFLAGS_EXCL
and maybe does not return all possible values in all posible cases ( ERRNO_EXIST / ERRNO_NOTDIR )

@konsumer
Copy link
Owner

Notes from discord:

  • the fd is not allocated when creating
  • it should test for file, then if file is not there, test for valid parent and rights to create in it
  • leads to fopen with mode w/w+ failing right now
  • needs logic here

konsumer added a commit that referenced this issue Nov 14, 2024
@konsumer konsumer reopened this Nov 16, 2024
@pmp-p pmp-p changed the title path_open / OFLAGS_CREAT path_open all flags support Nov 16, 2024
@konsumer
Copy link
Owner

Coming back to this issue, what actionable changes are needed? Is this an actual feature you need for something, or is it a "it would be better if it followed the spec" sort of thing?

@pmp-p
Copy link
Contributor Author

pmp-p commented Jan 16, 2025

it would be for full support of underlying emscripten FS / browserFS / zenfs in case a user wasip1 program / plugin extension requires complete fs functions. Did not happen yet in my use case but i expect it will happen.

@konsumer
Copy link
Owner

Did the 4b892dc commit resolve it (with your PR?)

@pmp-p
Copy link
Contributor Author

pmp-p commented Jan 16, 2025

No i'm quite sure it is very incomplete for all the combinations possible with OFLAGS_CREAT/OFLAGS_DIRECTORY/OFLAGS_EXCL/OFLAGS_TRUNC from oflags against fsRightsBase/fsRightsInheriting

@konsumer
Copy link
Owner

Ah, ok. I will leave the issue until someone needs it. I am not totally sure I understand what is missing, but so far I have been ok without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants