-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
path_open all flags support #6
Comments
Notes from discord:
|
Coming back to this issue, what actionable changes are needed? Is this an actual feature you need for something, or is it a "it would be better if it followed the spec" sort of thing? |
it would be for full support of underlying emscripten FS / browserFS / zenfs in case a user wasip1 program / plugin extension requires complete fs functions. Did not happen yet in my use case but i expect it will happen. |
Did the 4b892dc commit resolve it (with your PR?) |
No i'm quite sure it is very incomplete for all the combinations possible with OFLAGS_CREAT/OFLAGS_DIRECTORY/OFLAGS_EXCL/OFLAGS_TRUNC from oflags against fsRightsBase/fsRightsInheriting |
Ah, ok. I will leave the issue until someone needs it. I am not totally sure I understand what is missing, but so far I have been ok without it. |
it seems path_open does not allocate fd when passed OFLAGS_CREAT, does not handle OFLAGS_EXCL
and maybe does not return all possible values in all posible cases ( ERRNO_EXIST / ERRNO_NOTDIR )
The text was updated successfully, but these errors were encountered: