Черных Илья #214
Open
Черных Илья #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsitin
reviewed
Dec 11, 2024
Comment on lines
31
to
36
| public PrintingConfig<TOwner> Using(CultureInfo culture) | ||
| { | ||
| printingConfig.SpecifyTheCulture<TPropType>(culture); | ||
|
|
||
| return ParentConfig; | ||
| } |
There was a problem hiding this comment.
Сейчас можно написать что-то вроде ObjectPrinter.For<Person>().Printing(x=> x.Age).Using(CultureInfo.InvariantCulture) и ожидаемым поведением будет применение культуры только к выбранному полю, а не всем полям с таким же типом. Стоит сделать, чтобы примениялось только к конкретному полю
| { | ||
| public class PrintingConfig<TOwner> | ||
| private readonly HashSet<Type> finalTypes = |
There was a problem hiding this comment.
В шарпе есть ещё куча базовых типов, но как минимум стоит добавть сериализацию для long и bool
ObjectPrinting/PrintingConfig.cs
Outdated
| IFormattable format => | ||
| format.ToString(null, CultureInfo.InvariantCulture), | ||
| string str => str, | ||
| _ => (string)obj |
There was a problem hiding this comment.
Такой каст в строку может стрельнуть, если тип не кастуется в строку. К примеру, bool так не кастуется
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xsitin