Степан Заколюкин #33
Open
Степан Заколюкин #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ектах: при добавлении новых полей в класс Person не придется вносить изменений в код тестирующего метода; кроме того для сравнения объектов Person используется более читаемый синтаксис
Inree
reviewed
Nov 7, 2024
Comment on lines
+28
to
+38
| public int GetHashCode() | ||
| { | ||
| var result = 0; | ||
| var degree = 0; | ||
| foreach (var field in GetType().GetFields()) | ||
| { | ||
| if (field.IsStatic || field.Name == "Id") continue; | ||
| result += (int)Math.Pow(field.GetValue(this).GetHashCode(), ++degree); | ||
| } | ||
|
|
||
| return result; |
There was a problem hiding this comment.
оч тяжёлые операции для GetHashCode. будут тратить много времени если царей будет много
| ClassicAssert.AreEqual(expectedTsar.Parent.Age, actualTsar.Parent.Age); | ||
| ClassicAssert.AreEqual(expectedTsar.Parent.Height, actualTsar.Parent.Height); | ||
| ClassicAssert.AreEqual(expectedTsar.Parent.Parent, actualTsar.Parent.Parent); | ||
| actualTsar.Should().Be(expectedTsar); |
There was a problem hiding this comment.
Я так понял ты написал GetHashCode и Equals чтобы тут была одна строчка
Кажется, тут задумывалось другое решение. Погугли у fluent assertions метод сравнения объектов по структуре. Он умеет сравнивать объекты в одну строчку и без GetHashCode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Inreek