Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking "Runtime Status" of extension shows 2 "error" messages - potential for some confusion to a new user #367

Open
jwmatthews opened this issue Feb 12, 2025 · 1 comment

Comments

@jwmatthews
Copy link
Member

Version: 0.0.10

When I bring up "Runtime Status", I see the below 2 messages relating to the 'proposed api' usage for diff/merge view.

I'm filing this issue to see what team thinks about this, do we want to keep the messages displayed here to warn that we have something funky happening using some APIs that haven't yet become official? Is there concern of this confusing an end user to think something is in a broken state, when this is actually expected and things are OK?

Image
Runtime Status
Activation
Activated by onWalkthrough:konveyor-setup event: 0ms

Messages (2)
 diffEditor/gutter/selection is a proposed menu identifier. It requires 'package.json#enabledApiProposals: ["contribDiffEditorGutterToolBarMenus"]' and is only available when running out of dev or with the following command line switch: --enable-proposed-api konveyor.konveyor-ai

 diffEditor/gutter/hunk is a proposed menu identifier. It requires 'package.json#enabledApiProposals: ["contribDiffEditorGutterToolBarMenus"]' and is only available when running out of dev or with the following command line switch: --enable-proposed-api konveyor.konveyor-ai
@rszwajko
Copy link
Contributor

@jwmatthews @sjd78
just to give some context:

  1. feature that triggers those errors was added in ✨ Add Apply Block command #102
  2. because of the discovered problems we added ✨ Support reviewing resolutions with merge editor #103
  3. dev mode was fixed in 👻 Enable use of a proposed api in dev mode #222
  4. the default editor was changed in ✨ Change default diff editor to merge #322

The remaining problems are:

  1. publishing to the marketplace - as described in 👻 Enable use of a proposed api in dev mode #222
  2. warnings that may confuse the user - as described here
  3. simplifying using diff editor for demos - right now user needs to install from vsix and either:
    • launch with "--enable-proposed-api=konveyor.konveyor-ai switch (see sharing-extensions-using-the-proposed-api) OR
    • permanently add our extension to privileged extensions in the VS Code internal config(after every update):
      # on Linux under /usr/share/code/resources/app/product.json
      "extensionEnabledApiProposals": {
                      "konveyor.konveyor-ai":["contribDiffEditorGutterToolBarMenus"],
       
      

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants